Skip to content

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Feb 8, 2026

validate

@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 8, 2026 3:36pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 8, 2026 3:36pm
npmx-lunaria Ignored Ignored Feb 8, 2026 3:36pm

Request Review

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Compare/PackageSelector.vue 93.54% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

This pull request adds asynchronous package existence validation to the PackageSelector component. When users press Enter to add a package, the component now calls checkPackageExists to verify the package name before adding it. The component introduces isCheckingPackage and packageError state variables, disables the input during validation, displays a spinner icon whilst checking, and shows error messages for non-existent packages. The associated test file is updated to mock the validation function and verify that only existing packages are added, whilst non-existent ones trigger error alerts.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request description consists solely of an image demonstrating the validation feature, with no textual explanation of the changes made. Add a written description explaining the changes, implementation details, and rationale behind the package existence validation feature.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevv ghostdevv requested a review from serhalp February 8, 2026 19:46
@serhalp
Copy link
Contributor

serhalp commented Feb 8, 2026

🤔 @iiio2 could you explain what problem this is solving? I tried poking around in the app and I couldn't find a scenario this would change.

@iiio2
Copy link
Contributor Author

iiio2 commented Feb 9, 2026

@serhalp , I thought I can provide validation when no package found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants