Skip to content

feat(ui): use icon-only when connected to services #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatteoGabriele wants to merge 13 commits into
base: main
Choose a base branch
from
+20 −80
Open

feat(ui): use icon-only when connected to services #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ec7873b
feat(ui): use icon-only when connected to services
MatteoGabriele Feb 8, 2026
ecefee3
refactor: use top-0
MatteoGabriele Feb 8, 2026
8a23424
feat: add connected text a11y
MatteoGabriele Feb 8, 2026
86a9319
fix: remove unused computed
MatteoGabriele Feb 8, 2026
daddc9e
refactor: use service icon
MatteoGabriele Feb 8, 2026
6ee38bb
refactor: remove unused variable
MatteoGabriele Feb 8, 2026
4618252
chore: remove unused translation
MatteoGabriele Feb 8, 2026
7a2b77d
feat: change icons on mobile menu
MatteoGabriele Feb 8, 2026
a16e4df
Merge branch 'main' into feat/use-icon-when-connected
MatteoGabriele Feb 8, 2026
3a4e132
fix: remove unused variable
MatteoGabriele Feb 8, 2026
69e4934
Merge branch 'feat/use-icon-when-connected' of https://github.com/Mat…
MatteoGabriele Feb 8, 2026
56b3ec9
fix(a11y): add label when there are connections
MatteoGabriele Feb 8, 2026
84fe0f9
chore: remove comment
MatteoGabriele Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 14 additions & 52 deletions app/components/Header/AccountMenu.client.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const {
isConnected: isNpmConnected,
isConnecting: isNpmConnecting,
npmUser,
avatar: npmAvatar,
Copy link
Member

@danielroe danielroe Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still wondering if it makes sense to show avatars in the dropdown, even if not in the top level .... 🤔

wdyt?

Copy link
Contributor Author

@MatteoGabriele MatteoGabriele Feb 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may look a bit confusing and inconsistent.
If I have to go with avatars, which I do like because they give the impression that I've actually connected, I prefer the initial proposal.

activeOperations,
hasPendingOperations,
} = useConnector()
Expand Down Expand Up @@ -71,42 +70,27 @@ function openAuthModal() {
:class="hasBothConnections ? '-space-x-2' : ''"
>
<!-- npm avatar (first/back) -->
<img
v-if="isNpmConnected && npmAvatar"
:src="npmAvatar"
:alt="npmUser || $t('account_menu.npm_cli')"
width="24"
height="24"
class="w-6 h-6 rounded-full ring-2 ring-bg object-cover"
/>
<span
v-else-if="isNpmConnected"
v-if="isNpmConnected"
class="w-6 h-6 rounded-full bg-bg-muted ring-2 ring-bg flex items-center justify-center"
>
<span class="i-carbon-terminal w-3 h-3 text-fg-muted" aria-hidden="true" />
<span class="i-simple-icons:npm w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>

<!-- Atmosphere avatar (second/front, overlapping) -->
<img
v-if="atprotoUser?.avatar"
:src="atprotoUser.avatar"
:alt="atprotoUser.handle"
width="24"
height="24"
class="w-6 h-6 rounded-full ring-2 ring-bg object-cover"
:class="hasBothConnections ? 'relative z-10' : ''"
/>
<span
v-else-if="atprotoUser"
v-if="atprotoUser"
class="w-6 h-6 rounded-full bg-bg-muted ring-2 ring-bg flex items-center justify-center"
:class="hasBothConnections ? 'relative z-10' : ''"
>
<span class="i-carbon-cloud w-3 h-3 text-fg-muted" aria-hidden="true" />
<span class="i-simple-icons:maildotru w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>
</div>

<!-- "connect" text when not connected -->
<span v-if="!hasAnyConnection" class="font-mono text-sm">
<span v-if="hasAnyConnection" class="sr-only">
{{ $t('account_menu.account') }}
</span>
<span v-else class="font-mono text-sm">
{{ $t('account_menu.connect') }}
</span>

Expand Down Expand Up @@ -149,19 +133,8 @@ function openAuthModal() {
class="w-full px-3 py-2.5 flex items-center gap-3 hover:bg-bg-muted transition-colors text-start rounded-md"
@click="openConnectorModal"
>
<img
v-if="npmAvatar"
:src="npmAvatar"
:alt="npmUser"
width="32"
height="32"
class="w-8 h-8 rounded-full object-cover"
/>
<span
v-else
class="w-8 h-8 rounded-full bg-bg-muted flex items-center justify-center"
>
<span class="i-carbon-terminal w-4 h-4 text-fg-muted" aria-hidden="true" />
<span class="w-8 h-8 rounded-full bg-bg-muted flex items-center justify-center">
<span class="i-simple-icons:npm w-4 h-4 text-fg-muted" aria-hidden="true" />
</span>
<div class="flex-1 min-w-0">
<div class="font-mono text-sm text-fg truncate">~{{ npmUser }}</div>
Expand Down Expand Up @@ -192,19 +165,8 @@ function openAuthModal() {
class="w-full px-3 py-2.5 flex items-center gap-3 hover:bg-bg-muted transition-colors text-start rounded-md"
@click="openAuthModal"
>
<img
v-if="atprotoUser.avatar"
:src="atprotoUser.avatar"
:alt="atprotoUser.handle"
width="32"
height="32"
class="w-8 h-8 rounded-full object-cover"
/>
<span
v-else
class="w-8 h-8 rounded-full bg-bg-muted flex items-center justify-center"
>
<span class="i-carbon-cloud w-4 h-4 text-fg-muted" aria-hidden="true" />
<span class="w-8 h-8 rounded-full bg-bg-muted flex items-center justify-center">
<span class="i-simple-icons:maildotru w-4 h-4 text-fg-muted" aria-hidden="true" />
</span>
<div class="flex-1 min-w-0">
<div class="font-mono text-sm text-fg truncate">@{{ atprotoUser.handle }}</div>
Expand Down Expand Up @@ -234,7 +196,7 @@ function openAuthModal() {
class="i-carbon-circle-dash w-4 h-4 text-yellow-500 animate-spin"
aria-hidden="true"
/>
<span v-else class="i-carbon-terminal w-4 h-4 text-fg-muted" aria-hidden="true" />
<span v-else class="i-simple-icons:npm w-4 h-4 text-fg-muted" aria-hidden="true" />
</span>
<div class="flex-1 min-w-0">
<div class="font-mono text-sm text-fg">
Expand All @@ -256,7 +218,7 @@ function openAuthModal() {
@click="openAuthModal"
>
<span class="w-8 h-8 rounded-full bg-bg-muted flex items-center justify-center">
<span class="i-carbon-cloud w-4 h-4 text-fg-muted" aria-hidden="true" />
<span class="i-simple-icons:maildotru w-4 h-4 text-fg-muted" aria-hidden="true" />
</span>
<div class="flex-1 min-w-0">
<div class="font-mono text-sm text-fg">
Expand Down
34 changes: 6 additions & 28 deletions app/components/Header/MobileMenu.client.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useAtproto } from '~/composables/atproto/useAtproto'

const isOpen = defineModel<boolean>('open', { default: false })

const { isConnected, npmUser, avatar: npmAvatar } = useConnector()
const { isConnected, npmUser } = useConnector()
const { user: atprotoUser } = useAtproto()

const navRef = useTemplateRef('navRef')
Expand Down Expand Up @@ -114,19 +114,8 @@ onUnmounted(deactivate)
class="w-full flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200 text-start"
@click="handleShowConnector"
>
<img
v-if="npmAvatar"
:src="npmAvatar"
:alt="npmUser"
width="20"
height="20"
class="w-5 h-5 rounded-full object-cover"
/>
<span
v-else
class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center"
>
<span class="i-carbon-terminal w-3 h-3 text-fg-muted" aria-hidden="true" />
<span class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center">
<span class="i-simple-icons:npm w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>
<span class="flex-1">~{{ npmUser }}</span>
<span class="w-2 h-2 rounded-full bg-green-500" aria-hidden="true" />
Expand All @@ -139,19 +128,8 @@ onUnmounted(deactivate)
class="w-full flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200 text-start"
@click="handleShowAuth"
>
<img
v-if="atprotoUser.avatar"
:src="atprotoUser.avatar"
:alt="atprotoUser.handle"
width="20"
height="20"
class="w-5 h-5 rounded-full object-cover"
/>
<span
v-else
class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center"
>
<span class="i-carbon-cloud w-3 h-3 text-fg-muted" aria-hidden="true" />
<span class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center">
<span class="i-simple-icons:maildotru w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>
<span class="flex-1 truncate">@{{ atprotoUser.handle }}</span>
</button>
Expand All @@ -164,7 +142,7 @@ onUnmounted(deactivate)
@click="handleShowAuth"
>
<span class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center">
<span class="i-carbon-cloud w-3 h-3 text-fg-muted" aria-hidden="true" />
<span class="i-simple-icons:maildotru w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>
<span class="flex-1">{{ $t('account_menu.connect_atmosphere') }}</span>
</button>
Expand Down
Loading