-
-
Notifications
You must be signed in to change notification settings - Fork 233
feat: add permalink to downloads modal #1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add permalink to downloads modal #1299
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe PR extracts chart-related type definitions from component files into a centralised Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
This introduces a regression, the data fetched does not correspond to the expected range:
Also, the refresh button next to the date inputs, that shows when changing the date or granularity, stays visible when used, yet it should only appear when the selection or granularity is different than the default 52 weeks |
Adds query parameter handling to the package page to support a permalink for the downloads modal.
When present, the modal opens on page load and persists across refreshes.
Included parameters: granularity, start date, and end date.
Screen.Recording.2026-02-09.at.22.19.01.mov
closes #516