-
-
Notifications
You must be signed in to change notification settings - Fork 237
feat: replace links in markdown instead of via javascript #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace links in markdown instead of via javascript #1339
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
0dc35ee to
e30cb04
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdated Readme.vue to ignore clicks with modifier keys or non-primary buttons, expanded anchor handling to treat both hash ( Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Ooopsie daisy
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Alex Savelyev <91429106+alexdln@users.noreply.github.com>
|
@essenmitsosse Just remembered one more weird behavior with this "new tab" markers
|
|
@essenmitsosse It seems that if you specify for |
|
@alexdln can't make it inline because, then the icon does not work. I don't think there is a robust solution that doesn't make the problem worse then it currently is. |
|
@essenmitsosse Have you checked by adding |
|
the JS handler will still be needed for client-side navigation, which will be more performant, but you can update it to check if window.location is the same as the href origin. |
@danielroe what do you mean by that? Why do we need a JS handler for client side navigation? |
|
because nuxt doesn't listen to clicks on |
|
Aw shucks! |
Co-authored-by: Alex Savelyev <91429106+alexdln@users.noreply.github.com>
|
No sorcery, just uno adds a mask with icon under the current container. And since you had an inline with no content, its width was 0. So you just needed to increase the width. You can't use width for an inline, but you can use content that won't be visible and preferably won't interfere with the mask and not wrapping |
If that is not sorcery, what is then. 😂 But glad it works! |
Co-authored-by: Daniel Roe <daniel@roe.dev>
I also added a check for modifier keys, so |
Co-authored-by: Daniel Roe <daniel@roe.dev>


Currently all links in the readme are intercepted via JavaScript and if they go to npmjs.com redirected to npmx.dev. This has several problems, most of which stem from the fact, that the link in the URL is not the link we are going to.
This PR:
and removes the JavaScript handler(JavaScript handler is still needed for code copy button)Good example readme: /package/is-odd