Skip to content

Conversation

@nicolo-ribaudo
Copy link
Contributor

Fixes #1341

This makes the ./ in the logo fully behave like an image, rather than it being half-selectable.

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 4:50pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 4:50pm
npmx-lunaria Ignored Ignored Feb 10, 2026 4:50pm

Request Review

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

The AppLogo component in app/components/AppLogo.vue was modified to add a user-select: none style attribute to the <text> element. This single-line addition prevents the logo text from being selected by users, addressing inconsistent selection behaviour where certain characters within the logo were selectable whilst others were not. The change contains no modifications to the component's structure or logic.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly references issue #1341 and explains the intended fix of making the logo's / non-selectable to behave like an image.
Linked Issues check ✅ Passed The change adds user-select: none to the SVG text element, which addresses the core issue of inconsistent selection behaviour reported in #1341.
Out of Scope Changes check ✅ Passed The modification is limited to adding a style attribute to prevent text selection in AppLogo.vue, which is directly aligned with the linked issue's objectives.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@knowler knowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@danielroe danielroe added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit 90fecf8 Feb 10, 2026
17 checks passed
@github-actions
Copy link

Thanks for your first contribution, @nicolo-ribaudo! ✨

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

@nicolo-ribaudo nicolo-ribaudo deleted the logo-slash-select branch February 10, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird selection behavior for the ./npmx logo on the home page

3 participants