-
-
Notifications
You must be signed in to change notification settings - Fork 238
fix: prevent trends date input from being disabled while typing #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughA new exported constant 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
I think restricting to 4-digit years would be safe 😆 (and good ux!) |
|
Thanks! I'll update the PR right away. |
|
done! |
# Conflicts: # app/components/Package/TrendsChart.vue
this pr:
Video
trends.mp4
Question for Maintainers: I noticed that the native HTML
<input type="date">behavior allows for 6-digit years (e.g.,202612) by default. Should I addmax="9999-12-31"to restrict the input to 4-digit years? I'm happy to include that in this PR if you think it's better for the UX.