Skip to content

Conversation

@mikouaji
Copy link
Contributor

Only missing translations are a11y and privacy policy page.
Added small fix to english file.

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 11, 2026 8:03am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 11, 2026 8:03am
npmx-lunaria Ignored Ignored Feb 11, 2026 8:03am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 11, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-GB.json Localization changed, will be marked as complete.
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
lunaria/files/pl-PL.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

This PR updates i18n locale JSONs. English files (i18n/locales/en.json, lunaria/files/en-GB.json, lunaria/files/en-US.json) change search.found_packages_sorted to add a leading "No results found" variant. Polish files (i18n/locales/pl-PL.json, lunaria/files/pl-PL.json) receive extensive localization additions and restructures: footer.keyboard_shortcuts, expanded shortcuts.section, many search keys, settings.data_source, provenance_section, security_downgrade, trends, likes, downloads.community_distribution, size unit mappings, copy_as_markdown, totalLikes, and removal of the privacy_policy block. No code logic or API signatures changed.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description directly relates to the changeset, describing the addition of missing Polish translations and a small English fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
lunaria/files/pl-PL.json (1)

939-942: Consider simplifying the description wording.

The description "Liczba posiadanych polubień" (number of possessed likes) is grammatically correct but slightly formal. A more natural phrasing would be "Łączna liczba polubień" (total number of likes) or simply "Liczba polubień".

💬 Suggested copy refinement
         "totalLikes": {
           "label": "Polubienia",
-          "description": "Liczba posiadanych polubień"
+          "description": "Łączna liczba polubień"
         },

@danielroe danielroe added this pull request to the merge queue Feb 11, 2026
Merged via the queue into npmx-dev:main with commit 9aae078 Feb 11, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants