-
-
Notifications
You must be signed in to change notification settings - Fork 355
fix: correctly parse package name for scoped packages #2135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MatteoGabriele
merged 6 commits into
npmx-dev:main
from
gameroman:fix-compare-page-scoped-package
Mar 19, 2026
+97
−2
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c7c54fe
tests: add tests for `parsePackageParams`
gameroman 2c0f0cb
fix: correctly decode `rawPackageName`
gameroman e57d3ee
test: add suggested e2e test by rabbit
gameroman 35e613f
[autofix.ci] apply automated fixes
autofix-ci[bot] 8613899
fix test
gameroman 7142d6d
test: remove hallucinated thing
gameroman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { parsePackageParams } from '#server/utils/parse-package-params' | ||
|
|
||
| describe('parsePackageParams', () => { | ||
| describe('unscoped packages', () => { | ||
| it('parses package name without version', () => { | ||
| const segments = ['vue'] | ||
| const result = parsePackageParams(segments) | ||
| expect(result).toEqual({ | ||
| rawPackageName: 'vue', | ||
| rawVersion: undefined, | ||
| }) | ||
| }) | ||
|
|
||
| it('parses package name with version', () => { | ||
| const segments = ['vue', 'v', '3.4.0'] | ||
| const result = parsePackageParams(segments) | ||
| expect(result).toEqual({ | ||
| rawPackageName: 'vue', | ||
| rawVersion: '3.4.0', | ||
| }) | ||
| }) | ||
|
|
||
| it('parses package name with prerelease version', () => { | ||
| const segments = ['nuxt', 'v', '4.0.0-rc.1'] | ||
| const result = parsePackageParams(segments) | ||
| expect(result).toEqual({ | ||
| rawPackageName: 'nuxt', | ||
| rawVersion: '4.0.0-rc.1', | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('scoped packages', () => { | ||
| it('parses scoped package name without version', () => { | ||
| const segments = ['@nuxt', 'kit'] | ||
| const result = parsePackageParams(segments) | ||
| expect(result).toEqual({ | ||
| rawPackageName: '@nuxt/kit', | ||
| rawVersion: undefined, | ||
| }) | ||
| }) | ||
|
|
||
| it('parses scoped package name with version', () => { | ||
| const segments = ['@nuxt', 'kit', 'v', '1.0.0'] | ||
| const result = parsePackageParams(segments) | ||
| expect(result).toEqual({ | ||
| rawPackageName: '@nuxt/kit', | ||
| rawVersion: '1.0.0', | ||
| }) | ||
| }) | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.