-
-
Notifications
You must be signed in to change notification settings - Fork 238
test: mock connector for e2e/browser/local dev #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b24d8b3
d169a85
f006897
be6aa99
074d2da
11d3781
9d14c22
d825361
b143ce6
b4113e4
c039fd0
29c09b1
44fa3fd
7963f47
70b1f28
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,10 +17,7 @@ | |
| "npmx-connector": "./dist/cli.mjs" | ||
| }, | ||
| "exports": { | ||
| ".": { | ||
| "import": "./dist/index.mjs", | ||
| "types": "./dist/index.d.mts" | ||
| } | ||
| ".": "./dist/index.mjs" | ||
| }, | ||
|
Comment on lines
19
to
21
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cat -n cli/package.json | head -50Repository: npmx-dev/npmx.dev Length of output: 1657 🏁 Script executed: rg "from\s+['\"]npmx-connector['\"]|import.*npmx-connector" --type ts --type jsRepository: npmx-dev/npmx.dev Length of output: 43 🏁 Script executed: fd tsconfig -E node_modulesRepository: npmx-dev/npmx.dev Length of output: 92 🏁 Script executed: ls -la cli/dist/ 2>/dev/null || echo "dist directory not found or empty"Repository: npmx-dev/npmx.dev Length of output: 94 🏁 Script executed: git log --oneline -n 20 cli/package.json 2>/dev/null | head -10Repository: npmx-dev/npmx.dev Length of output: 136 🏁 Script executed: git show HEAD:cli/package.json 2>/dev/null | sed -n '19,25p'Repository: npmx-dev/npmx.dev Length of output: 152 🏁 Script executed: cat -n cli/tsconfig.jsonRepository: npmx-dev/npmx.dev Length of output: 532 🏁 Script executed: git diff HEAD~1 cli/package.json 2>/dev/null || echo "Unable to get diff"Repository: npmx-dev/npmx.dev Length of output: 79 🏁 Script executed: git status cli/package.jsonRepository: npmx-dev/npmx.dev Length of output: 126 🌐 Web query:
💡 Result: To make tsdown emit TypeScript declaration files (
Common dts-related options/notes:
Citations:
🏁 Script executed: git log --all --oneline cli/package.json 2>/dev/null | head -20Repository: npmx-dev/npmx.dev Length of output: 1108 🏁 Script executed: git show HEAD~5:cli/package.json 2>/dev/null | grep -A 5 "exports" || echo "Cannot access earlier commit"Repository: npmx-dev/npmx.dev Length of output: 89 🏁 Script executed: fd tsdown.config -E node_modulesRepository: npmx-dev/npmx.dev Length of output: 81 🏁 Script executed: git show 588e1a1:cli/package.json 2>/dev/null | grep -A 5 "exports" || echo "Cannot access that commit"Repository: npmx-dev/npmx.dev Length of output: 169 🏁 Script executed: git show 1f03429:cli/package.json 2>/dev/null | grep -A 5 "exports" || echo "Cannot access that commit"Repository: npmx-dev/npmx.dev Length of output: 169 🏁 Script executed: cat -n cli/tsdown.config.tsRepository: npmx-dev/npmx.dev Length of output: 299 Restore types entry to exports object for TypeScript consumers. The exports field was simplified from |
||
| "files": [ | ||
| "dist" | ||
|
|
@@ -29,6 +26,7 @@ | |
| "build": "tsdown", | ||
| "dev": "NPMX_CLI_DEV=true node src/cli.ts", | ||
| "dev:debug": "DEBUG=npmx-connector NPMX_CLI_DEV=true node src/cli.ts", | ||
| "dev:mock": "NPMX_CLI_DEV=true node src/mock-server.ts", | ||
| "test:types": "tsc --noEmit" | ||
| }, | ||
| "dependencies": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add language identifier to the fenced code block.
The code block showing the directory structure is missing a language identifier, which violates the markdownlint rule MD040. Add a language identifier to maintain consistency with the project's documentation standards.
📝 Proposed fix
🧰 Tools
🪛 markdownlint-cli2 (0.20.0)
[warning] 798-798: Fenced code blocks should have a language specified
(MD040, fenced-code-language)