Skip to content

Add php 7 and 8#59

Open
b1rdex wants to merge 1 commit into
nrk:v1.1from
b1rdex:patch-1
Open

Add php 7 and 8#59
b1rdex wants to merge 1 commit into
nrk:v1.1from
b1rdex:patch-1

Conversation

@b1rdex

@b1rdex b1rdex commented Mar 21, 2019

Copy link
Copy Markdown

Had to drop php 5.3

@b1rdex b1rdex marked this pull request as ready for review March 21, 2019 14:49
@b1rdex b1rdex closed this Mar 21, 2019
@b1rdex b1rdex reopened this Mar 21, 2019
@b1rdex

b1rdex commented Mar 21, 2019

Copy link
Copy Markdown
Author

@b1rdex

b1rdex commented Mar 21, 2019

Copy link
Copy Markdown
Author

Here is last build log with CFLAGS set: https://travis-ci.com/b1rdex/phpiredis/builds/105302618

@b1rdex b1rdex changed the title Add php 7.1, 7.2 and 7.3 Add php 7.1, 7.2 and 7.3. Drop php 5.3 Mar 21, 2019
@b1rdex b1rdex changed the title Add php 7.1, 7.2 and 7.3. Drop php 5.3 Add php 7.1, 7.2, 7.3 and 7.4. Drop php 5.3, 5.4 and 5.5 Jul 31, 2020
@b1rdex

b1rdex commented Jul 31, 2020

Copy link
Copy Markdown
Author

@nrk

nrk commented Aug 26, 2020

Copy link
Copy Markdown
Owner

Hi @b1rdex, just wondering: would it be possible to keep tests running on PHP 5.3, 5.4 and 5.5 on Travis CI just like we did with Predis? We could also add PHP 8.0 while we are at this, planning to merge #66 in a few days.

@nrk nrk added the tests label Aug 26, 2020
@b1rdex b1rdex changed the base branch from v1.0 to v1.1 October 13, 2020 14:46
@b1rdex

b1rdex commented Oct 13, 2020

Copy link
Copy Markdown
Author

@nrk I've added 5.3, 5.4 and 5.5 back and added 8.0. The build passed (https://travis-ci.com/github/b1rdex/phpiredis/builds/189732401) except for 8.0. Then I decided to update the branch and rebase it over v1.1. And now it's broken: https://travis-ci.com/github/b1rdex/phpiredis/builds/189734122. I don't get why and can't fix it. What should I do next? 😄

Also, could you please fix Travis integration? Would be easier to see the build status here on GitHub.

@b1rdex b1rdex changed the title Add php 7.1, 7.2, 7.3 and 7.4. Drop php 5.3, 5.4 and 5.5 Add php 7 and 8 Oct 13, 2020
@b1rdex

b1rdex commented Oct 13, 2020

Copy link
Copy Markdown
Author

Actually, v1.1 branch errors too: https://travis-ci.com/github/b1rdex/phpiredis/builds/189735956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants