Skip to content

Conversation

@AnnaShaleva
Copy link
Member

Ref. nspcc-dev/neo-go#3745.

Let's firstly finalize nspcc-dev/neo-go#3835 before the merge, because we might want to add height parameter to WithSecondsPerBlock setting (to me it's not needed, but still may be considered).

@AnnaShaleva AnnaShaleva added this to the v0.3.3 milestone Mar 19, 2025
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.66%. Comparing base (6a1eac8) to head (b5dd36e).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
internal/consensus/consensus.go 0.00% 3 Missing ⚠️
config.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   57.86%   57.66%   -0.20%     
==========================================
  Files          33       33              
  Lines        2283     2277       -6     
==========================================
- Hits         1321     1313       -8     
- Misses        873      875       +2     
  Partials       89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

height parameter

But why if we're always running dbft for the next block?

@AnnaShaleva
Copy link
Member Author

AnnaShaleva commented Mar 19, 2025

But why if we're always running dbft for the next block?

As I said, I don't think it's needed, because every dependent service is OK with the current behaviour. I just wanted to hear your opinion.

Ref. nspcc-dev/neo-go#3745.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva
Copy link
Member Author

@roman-khimov, ready for review, it's the final implementation, we can merge it.

@roman-khimov roman-khimov merged commit 5281a9a into master Mar 20, 2025
12 checks passed
@roman-khimov roman-khimov deleted the dynamic-blocktime branch March 20, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants