-
Notifications
You must be signed in to change notification settings - Fork 4
*: adapt state-dependent block producing time #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 57.86% 57.66% -0.20%
==========================================
Files 33 33
Lines 2283 2277 -6
==========================================
- Hits 1321 1313 -8
- Misses 873 875 +2
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
height parameter
But why if we're always running dbft for the next block?
As I said, I don't think it's needed, because every dependent service is OK with the current behaviour. I just wanted to hear your opinion. |
Ref. nspcc-dev/neo-go#3745. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
0cd7c07 to
b5dd36e
Compare
|
@roman-khimov, ready for review, it's the final implementation, we can merge it. |
Ref. nspcc-dev/neo-go#3745.
Let's firstly finalize nspcc-dev/neo-go#3835 before the merge, because we might want to add
heightparameter toWithSecondsPerBlocksetting (to me it's not needed, but still may be considered).