refactor: derive v2 API host from baseUrl in resolveUrl#49
Merged
Conversation
resolveUrl hardcoded https://api.pipedrive.com for /api/v2/ endpoints, duplicating the host from baseUrl. Derive it by stripping the trailing /v1 so v1 and v2 always share the same host, even if baseUrl is ever pointed at a company-specific domain.
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the review nit from #34:
resolveUrlhardcodedhttps://api.pipedrive.comfor v2 endpoints instead of deriving it frombaseUrl. Now strips the trailing/v1so v1 and v2 share the same host (future-proof ifbaseUrlever becomes a company domain). Behaviour is identical for the current default host.Build ✅ · lint ✅ · tests ✅ (no regression in v2 endpoint tests).