[#64] Remove default implementation for ListItem#getUniqueProperty() #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fun getUniqueProperty(): Any { | ||
| return this::class.toString() | ||
| } | ||
| fun getUniqueProperty(): Any |
Contributor
There was a problem hiding this comment.
так тоді можна зробить як проперті і оверайдить в конструкторі
Contributor
Author
There was a problem hiding this comment.
это сильнее сломает compatibility, стоит ли оно того?
Contributor
There was a problem hiding this comment.
compatibility в будь якому випадку ламаєтсья - всім прийдеться перевизначить метод
Contributor
Author
There was a problem hiding this comment.
ну в идеале он и так должен быть переопределен везде, а значит не так уж и много придется добавлять всего.
но ок, я понял) в пн сделаю
vchernyshovnullgr
approved these changes
Oct 17, 2019
grishko188
approved these changes
Oct 17, 2019
vchernyshov
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.