Read playlist in chunks to avoid hitting MPDs max_output_buffer#124
Draft
maxmitti wants to merge 1 commit intonullobsi:mainfrom
Draft
Read playlist in chunks to avoid hitting MPDs max_output_buffer#124maxmitti wants to merge 1 commit intonullobsi:mainfrom
maxmitti wants to merge 1 commit intonullobsi:mainfrom
Conversation
|
Yup, this actually solves the problem. There are still connection errors in some places ("Play now and replace queue" or drag-and-drop for big playlists don't work) but it's possible to use "Append" or queue the playlist from another client; then Cantata can actually display the queue. Visually it also looks more responsive since the client starts displaying the queue sooner. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual issue is, that MPDs
max_output_buffersetting is exceeded.Apparently MPD simply drops the connection when that happens.
A workaround could be to increase the
max_output_buffersetting.The obvious client-side fix is to load the playlist in chunks, which this change does.
I am not too happy with the overall UX, though.
While the playlist is loaded (which can take multiple seconds) there is no indication that anything is happening, which can be confusing.
Fixes #72