fix: correct slippage conversion from basis points to decimal in PumpFun trades#28
Closed
0x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
Closed
Conversation
…Fun trades The slippage parameter was being divided by 100 instead of 10,000 when converting basis points to the decimal value expected by the pump-sdk. This caused users setting 50 bps (0.5%) slippage to actually allow 50% slippage on buy and sell operations, resulting in significant fund loss. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nullxnothing
requested changes
Apr 8, 2026
Owner
nullxnothing
left a comment
nullxnothing
left a comment
There was a problem hiding this comment.
I think this conversion is backwards for the installed pump SDK. In the current code, slippage is passed as input.slippageBps / 100, and the SDK types document that parameter as a percent value, not a decimal fraction. Changing it to / 10_000 would turn 100 bps from 1% into 0.01%, which is much stricter and likely to cause valid trades to fail rather than fix a safety issue. Please verify the SDK contract before merging this change.
Owner
|
Closed as superseded by #75, which reapplies the corrected security hardening on top of current main. This avoids merging stale/conflicted branches and preserves the fixes with passing CI/CodeQL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buyTokenandsellTokenwas divided by 100 instead of 10,000 when converting basis points to the decimal value expected by the pump-sdkbuyInstructionsandsellInstructionscalls to divide by 10,000Test plan
pnpm run typecheck— passes cleanpnpm run test— all wallet tests pass (19/19)