fix: validate trade amounts and add timeout to PumpFun IPFS upload#32
Open
0x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
Open
fix: validate trade amounts and add timeout to PumpFun IPFS upload#320x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
0x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
Conversation
buyToken and sellToken silently accepted zero amounts via ?? 0 defaults, allowing empty trades that waste network fees. Added early validation guards that reject non-positive amounts before any SDK or network calls. The IPFS metadata upload in createToken had no timeout, risking indefinite hangs. Added a 30-second AbortController timeout with a clear error message on expiry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buyTokenandsellTokensilently accepted zero/undefined amounts via?? 0defaults, allowing empty trades that waste network feescreateTokenhad no timeout, risking indefinite hangs if pump.fun is unresponsiveTest plan
pnpm run typecheck— passes cleanpnpm run test— all wallet tests pass (19/19)