fix: replace dynamic SQL column interpolation with static field mapping#34
Closed
0x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
Closed
fix: replace dynamic SQL column interpolation with static field mapping#340x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
0x-SquidSol wants to merge 1 commit intonullxnothing:mainfrom
Conversation
The agents:update handler built SQL SET clauses by interpolating filtered column names into the query string. While guarded by a whitelist and regex, this pattern is fragile and violates secure SQL practices. Replaced with a static AGENT_COLUMN_MAP object whose keys are the sole source of column names, eliminating the regex guard and making the allowed fields self-documenting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nullxnothing
requested changes
Apr 8, 2026
Owner
nullxnothing
left a comment
There was a problem hiding this comment.
This change weakens the whitelist instead of tightening it. key in AGENT_COLUMN_MAP on a plain object accepts inherited keys like oString and proto, so it is not equivalent to the previous explicit Set.has(...) check. If you want a static map, use Object.hasOwn(AGENT_COLUMN_MAP, key) or a null-prototype object; otherwise the whitelist claim here is not accurate.
Owner
|
Closed as superseded by #75, which reapplies the corrected security hardening on top of current main. This avoids merging stale/conflicted branches and preserves the fixes with passing CI/CodeQL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agents:updatehandler built SQL SET clauses by interpolating filtered column names into the query stringAGENT_COLUMN_MAPobject whose keys are the sole source of column namesTest plan
pnpm run typecheck— passes cleanpnpm run test— 234/234 pass (10 pre-existing failures in workspace profile tests, unrelated)