Restructured spaghetti code to fix #17 #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dex-file Restructured spaghetti code to fix numbbo#17
Contributor
|
Why do we get the above conflicts? |
joshua2705
commented
Jan 13, 2026
Author
There was a problem hiding this comment.
This is the line mentioned in the issue #17 (line no 499) which gets called repeatedly by the old architecture.
We removed this line and replaced it with a function which changes the architecture.
The function to this new line is imported in line 17.
joshua2705
commented
Jan 13, 2026
Author
There was a problem hiding this comment.
We used a venv for testing.
This can be removed if necessary
Contributor
There was a problem hiding this comment.
I don't exactly understand the causal link between these two.
In any case, you should rebase your branch on the current main branch, resolve possible conflicts, and update the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of DSBA open-source contribution project held by Prof.Dimo
We have attempted to fix issue #17
This architectural change makes the code more modular and manageable AND lead to a decrease in latency by 5.8%
But this is not the best solution. Ideally, it would be best to re-write the UI in vue/react to allow dynamic changes as per data