feat: return non-zero exit code on activation errors#378
Open
feat: return non-zero exit code on activation errors#378
Conversation
jfroche
force-pushed
the
fix/final-exit-code
branch
2 times, most recently
from
c17ab02 to
ea4f13e
Compare
Enabling nix by default force users to configure nix.settings to keep their previous configuration, which is not ideal. This commit disables nix by default and adds a test to ensure that enabling nix works correctly and that the nix.conf file is properly managed.
Use lazy_errors to accumulate errors during activation and return a non-zero exit code if any errors were encountered, while still applying as many changes as possible.
jfroche
force-pushed
the
fix/final-exit-code
branch
from
ea4f13e to
d189d6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use lazy_errors to accumulate errors during activation and return a non-zero exit code if any errors were encountered, while still applying as many changes as possible.
We also disable the nix module by default to avoid issues with existing nix configuration file. It is possible to enable it again by setting
nix.enabletotrueandit will replace the existing
/etc/nix/nix.conffile with the one generated by nix module.