Skip to content

feat: add environment.extraInit option#389

Merged
picnoir merged 1 commit intomainfrom
feat/environment.extraInit
Mar 9, 2026
Merged

feat: add environment.extraInit option#389
picnoir merged 1 commit intomainfrom
feat/environment.extraInit

Conversation

@jfroche
Copy link
Member

@jfroche jfroche commented Mar 6, 2026

No description provided.

@jfroche
Copy link
Member Author

jfroche commented Mar 6, 2026


This stack of pull requests is managed by jj-ryu.

@picnoir
Copy link
Member

picnoir commented Mar 9, 2026

Related to #225

@jfroche jfroche force-pushed the feat/environment.extraInit branch from 288b408 to 8d40ebe Compare March 9, 2026 09:57
Copy link
Member

@picnoir picnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This only implement part of the #225 story.

For bash, we're relying of the host (ubuntu, fedora, etc.) /etc/profile file, and hope that it'll load all the /etc/profile.d scripts. Seems like an appropriate expectation to have, that being said, maybe at some point we'd like to take full control of /etc/profile. I'm not sure.

As for zsh, it stays un-covered for now.

That being said, a partial solution is preferable to no solution at all.

Let's merge this as it is.

@picnoir picnoir merged commit d794108 into main Mar 9, 2026
3 checks passed
@picnoir picnoir deleted the feat/environment.extraInit branch March 9, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants