Merged
Conversation
Member
Author
This stack of pull requests is managed by jj-ryu. |
This was referenced Mar 6, 2026
Member
|
Related to #225 |
Pull Request: #386
288b408 to
8d40ebe
Compare
picnoir
approved these changes
Mar 9, 2026
Member
picnoir
left a comment
There was a problem hiding this comment.
LGTM.
This only implement part of the #225 story.
For bash, we're relying of the host (ubuntu, fedora, etc.) /etc/profile file, and hope that it'll load all the /etc/profile.d scripts. Seems like an appropriate expectation to have, that being said, maybe at some point we'd like to take full control of /etc/profile. I'm not sure.
As for zsh, it stays un-covered for now.
That being said, a partial solution is preferable to no solution at all.
Let's merge this as it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.