Skip to content

[18.0][OU-FIX] base: make the legacy module-state snapshot resume-friendly #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eantones wants to merge 2 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][OU-FIX] base: make the legacy module-state snapshot resume-friendly #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e1b32
[OU-FIX] base: make the legacy module-state snapshot resume-friendly
eantones Jul 7, 2026
cac9c00
[OU-FIX] base: guard the view_mode legacy column copy on resume
eantones Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions openupgrade_scripts/scripts/base/18.0.1.3/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,31 @@ def _fix_company_layout_background(cr):

@openupgrade.migrate(use_env=False)
def migrate(cr, version):
# IF NOT EXISTS: on a resumed run (crash after this script's work was
# committed but before base's version bump) the table already holds the
# correct pre-upgrade snapshot — recreating it here would either crash
# (DuplicateTable) or, worse, recapture states with the renames/merges
# below already applied. Keep the first capture.
openupgrade.logged_query(
cr,
f"""
CREATE TABLE {openupgrade.get_legacy_name("ir_module_module")
CREATE TABLE IF NOT EXISTS {openupgrade.get_legacy_name("ir_module_module")
} AS (SELECT name, state FROM ir_module_module);
""",
)
openupgrade.update_module_names(cr, renamed_modules.items())
openupgrade.update_module_names(cr, merged_modules.items(), merge_modules=True)
openupgrade.clean_transient_models(cr)
openupgrade.rename_xmlids(cr, _renamed_xmlids)
openupgrade.copy_columns(
cr,
{"ir_act_window_view": [("view_mode", None, None)]},
)
# Same resume story as the snapshot table above: the legacy column may
# already exist (and be filled) from a previously committed attempt.
if not openupgrade.column_exists(
cr, "ir_act_window_view", openupgrade.get_legacy_name("view_mode")
):
openupgrade.copy_columns(
cr,
{"ir_act_window_view": [("view_mode", None, None)]},
)
old_column = openupgrade.get_legacy_name("view_mode")
openupgrade.map_values(
cr,
Expand Down
Loading