optimize fish_completer path lookups#1963
Merged
Merged
Conversation
Contributor
|
Thanks. I'd like the $v to be a bit more verbose in name and also, it would be good to explain what's going on in the section below that describes what's happening. The cookbook needs to be able to explain itself. |
Check if string needs escaping before doing a path lookup. This avoids looking up the path, unless the completion contains special characters that need escaping
3ce66b8 to
3cc8008
Compare
Contributor
Author
I modified the section to add a short exlanation on the changes. Also renamed the closure variable to $row and the completion value variable to $value |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if string needs escaping before doing a path lookup. This avoids looking up the path, unless the completion contains special characters that need escaping