fix error USERNAME not exist in ssh-agent workaround script#2050
Merged
Conversation
Contributor
|
I think |
Contributor
Author
|
Ok so since the right variable is checked even if the left part is not null, there is no solution using the same command. Maybe |
Contributor
Author
|
I confirm it works perfectly. I will modify my PR. |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried the script on this page and was surprised to have it failed with the following error.
I fixed it by removing the part of the code where it defaults to the non-existing USERNAME. Maybe this var is needed in some other way, but in any case, I think this page needs to be updated.
PS: If this introduces error for other users ping me and I will update this PR