Be Sure that Expander Zones are Marked as Such #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A zone can be initially created by an alphanumeric fault message. When created this way, the expander attribute is not marked even for expander zones. However, when we receive an expander message, we should update the zone attribute to be sure it is identified as an expander.
edrikk
approved these changes
Feb 23, 2025
Contributor
edrikk
left a comment
edrikk
left a comment
There was a problem hiding this comment.
@ajschmidt8
Given that you have commit access, I wanted to flag a few PRs/changes that I've been running cleanly for a couple of years. These changes will also enable updating/correcting the requirements.txt file.
I'll using this same "approve" comment across these items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A zone can be initially created by an alphanumeric fault message.
When created this way, the expander attribute is not marked even
for expander zones.
However, when we receive an expander message, we should update
the zone attribute to be sure it is identified as an expander.