feat(client): allow to open potential lazy load components in editor#270
feat(client): allow to open potential lazy load components in editor#270huang-julien wants to merge 4 commits intomainfrom
Conversation
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change updates Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@client/app/pages/component-lazy-load.vue`:
- Around line 85-92: The anchors used solely as click handlers (calling
devtoolsClient?.devtools.rpc.openInEditor with imp.importSource and
imp.importedBy) are semantic/accessibility issues; replace the <a href="">
elements with <button type="button"> elements (preserving the displayed text {{
imp.importSource }} and {{ imp.importedBy }}) and keep the `@click` handlers on
those buttons, or alternatively add `@click.prevent` to the existing anchors to
stop navigation—change the elements around the calls to
devtoolsClient?.devtools.rpc.openInEditor(imp.importSource) and
devtoolsClient?.devtools.rpc.openInEditor(imp.importedBy).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aae2e72b-f92d-49a6-a94e-4e64c02e7d06
📒 Files selected for processing (1)
client/app/pages/component-lazy-load.vue
🔗 Linked issue
📚 Description