Skip to content

fix: require src prop in <NuxtImg> and <NuxtPicture> #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DamianGlowala wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

fix: require src prop in <NuxtImg> and <NuxtPicture> #2143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/runtime/components/NuxtImg.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ defineSlots<{ default(props: DefaultSlotProps): any }>()
const $img = useImage()
const { providerOptions, normalizedAttrs, imageModifiers } = useImageProps(props)

const sizes = computed(() => $img.getSizes(props.src!, {
const sizes = computed(() => $img.getSizes(props.src, {
...providerOptions.value,
sizes: props.sizes,
densities: props.densities,
Expand Down Expand Up @@ -86,7 +86,7 @@ const placeholder = computed(() => {
? placeholder
: typeof placeholder === 'number' ? [placeholder] : []

return $img(props.src!, {
return $img(props.src, {
...imageModifiers.value,
width,
height,
Expand All @@ -98,7 +98,7 @@ const placeholder = computed(() => {
const mainSrc = computed(() =>
props.sizes
? sizes.value.src
: $img(props.src!, imageModifiers.value, providerOptions.value),
: $img(props.src, imageModifiers.value, providerOptions.value),
)

const src = computed(() => placeholder.value || mainSrc.value)
Expand Down
6 changes: 3 additions & 3 deletions src/runtime/components/NuxtPicture.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const attrs = computed(() => {
return attrs
})

const originalFormat = computed(() => props.src?.match(/^[^?#]+\.(\w+)(?:$|[?#])/)?.[1])
const originalFormat = computed(() => props.src.match(/^[^?#]+\.(\w+)(?:$|[?#])/)?.[1])

const legacyFormat = computed(() => {
if (props.legacyFormat) {
Expand All @@ -97,7 +97,7 @@ const sources = computed<Source[]>(() => {
const formats = props.format?.split(',') || (originalFormat.value === 'svg' ? ['svg'] : ($img.options.format?.length ? [...$img.options.format] : ['webp']))

if (formats[0] === 'svg') {
return [{ src: props.src! }]
return [{ src: props.src }]
}

if (!formats.includes(legacyFormat.value)) {
Expand All @@ -109,7 +109,7 @@ const sources = computed<Source[]>(() => {
}

return formats.map((format) => {
const { srcset, sizes, src } = $img.getSizes(props.src!, {
const { srcset, sizes, src } = $img.getSizes(props.src, {
...providerOptions.value,
sizes: props.sizes || $img.options.screens,
densities: props.densities,
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/utils/props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useImage } from '#imports'

export interface BaseImageProps<Provider extends keyof ConfiguredImageProviders> {
// input source
src?: string
src: string

// modifiers
format?: string
Expand Down
Loading