feat(cli): add local embeddings setup to floop init

[nvandessel]

Summary

• Add --embeddings / --no-embeddings flags to floop init for downloading and enabling local embedding dependencies
• Create internal/setup/ package with DetectInstalled(), DownloadLibraries(), and DownloadEmbeddingModel() using yzma download APIs
• Add auto-detection of installed embedding deps in ~/.floop/ on MCP server startup (no explicit config needed after first setup)
• Interactive prompt in floop init for embeddings setup with skip-if-already-installed detection

Test plan

• internal/setup/ unit tests: DetectInstalled with various file layouts, DefaultFloopDir, libraryFileName
• Full test suite passes (go test ./... — 31 packages)
• Build passes (go build ./...)

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

Adds local embedding setup to floop init with auto-detection and download capabilities. Creates new internal/setup/ package with detection for llama.cpp libraries and GGUF models in ~/.floop/. Interactive mode prompts users to enable embeddings with skip-if-installed logic. MCP server now auto-detects installed embeddings at startup as a fallback when no explicit config exists.

Key changes:

• New --embeddings / --no-embeddings flags for CLI control
• setup.DetectInstalled() checks ~/.floop/lib/ for platform-specific libllama and ~/.floop/models/ for .gguf files
• setup.DownloadLibraries() and setup.DownloadEmbeddingModel() use yzma download APIs
• MCP server fallback: explicit config → auto-detect ~/.floop/ → no embeddings
• Config update writes LLM.Provider=local to ~/.floop/config.yaml after successful download

Issues found:

• Embedding setup errors silently ignored when --embeddings explicitly provided (line 108-118 in cmd_init.go)
• Custom string search implementation instead of strings.Contains() in tests

Confidence Score: 4/5

• Safe to merge with one logic issue to address regarding error handling
• Well-tested implementation with comprehensive unit tests and clear separation of concerns. The auto-detection fallback is well-designed. Main concern is that explicit --embeddings flag failures are downgraded to warnings rather than errors, which could confuse users who explicitly requested the feature. Dependencies add significant size but are already used by yzma.
• Review error handling in cmd/floop/cmd_init.go:108-118 to fail fast when --embeddings is explicitly provided

Important Files Changed

Filename	Overview
internal/setup/embeddings.go	New package for embedding setup - well-structured with clear separation of concerns for detection and download
cmd/floop/cmd_init.go	Adds embeddings flags and interactive prompts, with minor issue in error-swallowing logic
internal/mcp/server.go	Clean auto-detection fallback for embeddings - follows explicit config > auto-detect priority pattern
go.mod	Large dependency footprint from hashicorp/go-getter (AWS, GCS, S3) for downloads

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[floop init] --> B{Interactive or Flags?}
    B -->|Interactive| C[runInteractiveInit]
    B -->|Flags| D[Parse flags]
    
    C --> E{Embeddings installed?}
    E -->|Yes| F[Skip embeddings prompt]
    E -->|No| G[Prompt user for embeddings]
    
    D --> H{--embeddings flag?}
    H -->|Yes| I[doEmbeddings = true]
    H -->|No| J[doEmbeddings = false]
    
    F --> K[Return doEmbeddings=false]
    G --> L{User choice}
    L -->|Yes| M[Return doEmbeddings=true]
    L -->|No| K
    
    I --> N[setupEmbeddings]
    M --> N
    
    N --> O{Already installed?}
    O -->|Yes| P[Return already_installed]
    O -->|No| Q[DownloadLibraries]
    
    Q --> R[DownloadEmbeddingModel]
    R --> S[Update config.yaml]
    S --> T[Set LLM.Provider=local]
    
    T --> U[MCP Server Startup]
    U --> V{Config has LLM.Provider=local?}
    V -->|Yes| W[Use config paths]
    V -->|No| X[DetectInstalled ~/.floop/]
    
    X --> Y{Libs + Model found?}
    Y -->|Yes| Z[Auto-enable embedder]
    Y -->|No| AA[Continue without embeddings]
    
    W --> Z
    Z --> AB[Embedder available for semantic search]

Loading

_{Last reviewed commit: 2c9f74d}

[greptile-apps]

_{6 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}