docs(developers.md): Add sentence to ensure integer indexing (#3451) #3461
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Is there any intend to do anything with this? It would be lovely if this could be discussed/added. |
Contributor
|
Not really, since 1. the emoji are unprofessional and 2. the results are a list, which by definition is indexed by (consecutive) integers. |
Member
|
i dont see why we should merge this. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a single sentence to the developer.md about integer-indexing.
Fixes #3451
Type of change
Improvement to documentation.
How Has This Been Tested?
Does not apply to this pr.