Skip to content

Conversation

@beajeanm
Copy link
Contributor

@beajeanm beajeanm commented Dec 4, 2025

Make sure the fonction.outer includes the in keyword in, e.g.:

let f x = let g y = 1 in f (g 2)
^_____________^

Make sure the fonction.outer includes the in keyword `in`, e.g.:

let f x = let g y = 1 in f (g 2)
          ^_____________^
@kiyoon
Copy link
Collaborator

kiyoon commented Dec 6, 2025

make-range is removed in main

@beajeanm
Copy link
Contributor Author

@kiyoon Where can I read about the removal and the alternative to make-range? Thanks.

@kiyoon
Copy link
Collaborator

kiyoon commented Dec 11, 2025

The reason #make-range was necessary was due to the lack of support for quantified captures in previous neovim (#612). I'm not experienced in ocaml thus I don't understand what you're trying to achieve, but most likely the important parts should be supported by the language parser.

@beajeanm
Copy link
Contributor Author

Hmmm, ok, I'll see if I can figure it out.

I'm not experienced in ocaml thus I don't understand what you're trying to achieve

OCaml has top level and nested declaration, the nested ones are terminated by the in keyword. I was trying to include in in the function.outer group.
As you can see in the screenshot below "in" is not part of the value_definition node, so I was using make-range to work around that and capture both the cases with "in" and the case without "in".

Screenshot 2025-12-11 at 11 36 35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants