NV-4412 Retire the SARIF-to-GitLab converter for nightvision export gitlab#4
Merged
Merged
Conversation
…itlab The CLI now emits GitLab DAST reports natively (`nightvision export gitlab`), which fixes the defects this converter had: it labeled DAST findings as SAST and used the unstable rule id as the vulnerability id, so GitLab could not dedup across pipelines. Replace the converter body with a deprecation stub that errors with the migration command, so any pipeline still fetching this canonical script fails loudly with a pointer rather than silently producing a mislabeled report. The Azure DevOps converter is left in place: `export` does not yet cover Azure. Coordinated with the demo pipeline switch and the docs/skills repoint; all land together with the CLI release that ships `export gitlab`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI now emits GitLab DAST reports natively (
nightvision export gitlab), which fixes the defects this converter had: it labeled DAST findings as SAST and used the unstable rule id as the vulnerability id, so GitLab could not dedup across pipelines. Replace the converter body with a deprecation stub that errors with the migration command, so any pipeline still fetching this canonical script fails loudly with a pointer rather than silently producing a mislabeled report.The Azure DevOps converter is left in place:
exportdoes not yet cover Azure.Coordinated with the demo pipeline switch and the docs/skills repoint; all land together with the CLI release that ships
export gitlab.