Skip to content

TW-4827: add stored signatures support#48

Merged
qasim-nylas merged 1 commit intomainfrom
codex/TW-4827-disable-signature-write-retries
Apr 11, 2026
Merged

TW-4827: add stored signatures support#48
qasim-nylas merged 1 commit intomainfrom
codex/TW-4827-disable-signature-write-retries

Conversation

@qasim-nylas
Copy link
Copy Markdown
Collaborator

Summary

  • add stored signatures support to the CLI, including signature CRUD commands and signature_id support for send and draft flows
  • harden draft sending so --signature-id cannot stack or duplicate an already-managed stored signature
  • disable automatic retries for non-idempotent signature create/update requests to avoid replayed writes under retriable failures

What changed

  • added a new signatures adapter with demo/mock implementations and CLI commands for list/show/create/update/delete
  • wired signature_id through message send, draft create/send, and related request/domain types
  • added validation and support helpers around stored signatures, including protection for unsupported combinations
  • updated docs for the new email signatures commands and usage

Safety and behavior

  • CreateSignature and UpdateSignature no longer inherit the generic retry path used for idempotent requests
  • draft send now checks for an already-managed stored signature before allowing another --signature-id to be applied
  • coverage includes unit tests, adapter tests, CLI tests, and integration tests for signatures lifecycle and edge cases

Testing

  • make ci-full

Jira

  • Ticket: TW-4827
  • Epic: TW-4638

- add CLI and adapter support for stored signature CRUD and signature_id send/draft flows
- prevent duplicate signature application when sending drafts
- disable automatic retries for signature create/update writes
- add unit, integration, and docs coverage
@qasim-nylas qasim-nylas requested a review from AaronDDM April 11, 2026 13:34
Copy link
Copy Markdown
Collaborator

@AaronDDM AaronDDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@qasim-nylas qasim-nylas merged commit c96080e into main Apr 11, 2026
6 checks passed
@qasim-nylas qasim-nylas deleted the codex/TW-4827-disable-signature-write-retries branch April 11, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants