TW-4829: Harden CLI calendar scheduling flows and test coverage#49
Merged
qasim-nylas merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens the CLI calendar and timezone scheduling paths by replacing misleading or stubbed behavior with real scheduling logic, reducing duplicate helper code in touched paths, and restoring test discovery that was previously missing important coverage.
Jira
What changed
calendar ai schedulethrough real event-creation logic instead of reporting success without creating anythinginternal/adapters/ai/scheduler_tools.gocalendar find-timeand aligned it with shared scheduling logic09:30-17:30are handled correctlyinternal/cli/testutil/command.go*_test_basic.go/*_test_advanced.gofiles to real*_test.gonames sogo testdiscovers them normallyinternal/cli/dashboard/keys.goWhy this matters
Before this change, parts of the scheduling experience could report success without actually performing the underlying action, or return false negatives because the implementation was effectively stubbed. On top of that, some important tests were not being executed at all because of filename conventions, which made regressions easy to miss.
Validation
make ci-fullNotes
make ci-fullpassed on this branch immediately before opening the PR.