Kubernetes OpenAPI spec compatibility#129
Draft
curiousleo wants to merge 3 commits intonytimes:masterfrom
Draft
Conversation
Fixes nytimes#128 and nytimes#82. Changes: - Ignore $ref declarations that are not strings (dubious) - Allow builtins as RPC return types - Update Kubernetes proto fixture (dubious)
Author
|
I don't really understand how |
Author
|
Feedback welcome. Ping @jprobinson @lestrrat (you commented on #82 and seem to have some context on this). |
Author
|
@jprobinson and @lestrrat seem to have moved on from NYT. @JustinFullerNYT, do you have enough context on this project to provide feedback on this draft PR? |
I can take a look and recruit some others to look as well! |
|
@curiousleo / @JustinFullerNYT can we resurrect this? |
This was referenced May 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128 and #82.
Changes to make the Kubernetes fixture pass:
Additional changes:
I'm mostly feeling my way around at this point. I haven't tested the changes other than running
go test.