Updating link header type in createDataResource (when creating container) from Container to BasicContainer #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith all server implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The createDataResource function (which is called by the createIfAbsent method of a container), makes a POST request with a link header, which uses type
ldp#Container(if the URI argument ends with a slash--otherwise it should create an RDF resource).This works on solidweb.me, but doesn't work with solidcommunity.net (and possibly other pod providers using different server implementations), because it expects a container to be of type ldp#BasicContainer, and it creates an RDF resource (a ttl file) instead of a container.
In the unofficial Solid protocol, https://solidproject.org/TR/protocol#resource-containment, it says, "The representation and behaviour of containers in Solid corresponds to LDP Basic Container and MUST be supported by server."
So, apparently, using the Container type might work with some implementations, but the BasicContainer type should work with all servers (if they follow the unofficial protocol). I tested it, and this change does work for creating containers on both solidweb.me and solidcommunity.net.