Skip to content

Update Config documentation to clarify withdrawal conditions in KeepWhatsRaised #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahabubAlahi wants to merge 1 commit into
base: oz-audit-fixes
Choose a base branch
from
Open

Update Config documentation to clarify withdrawal conditions in KeepWhatsRaised #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/treasuries/KeepWhatsRaised.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ contract KeepWhatsRaised is IReward, BaseTreasury, TimestampChecker, ICampaignDa
struct Config {
/// @dev The minimum withdrawal amount required to qualify for fee exemption.
uint256 minimumWithdrawalForFeeExemption;
/// @dev Time delay (in timestamp) enforced before a withdrawal can be completed.
/// @dev Time delay (in timestamp) after the campaign deadline until which the campaign owner may withdraw.
/// Withdrawal is allowed only while current time is less than deadline + withdrawalDelay.
/// After deadline + withdrawalDelay, the withdrawal function is no longer callable.
uint256 withdrawalDelay;
/// @dev Time delay (in timestamp) before a refund becomes claimable or processed.
uint256 refundDelay;
Expand Down Expand Up @@ -840,7 +842,7 @@ contract KeepWhatsRaised is IReward, BaseTreasury, TimestampChecker, ICampaignDa
*
* Requirements:
* - Caller must be authorized.
* - Withdrawals must be enabled, not paused, and within the allowed time.
* - Withdrawals must be enabled, not paused, and within the withdrawal window (current time < deadline + withdrawalDelay).
* - Token must be accepted for the campaign.
* - For partial withdrawals:
* - `amount` > 0 and `amount + fees` ≤ available balance.
Expand Down