Skip to content

Add fee percentage validation in GlobalParams contract (OZ-32) #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahabubAlahi merged 1 commit into from
Mar 19, 2026
Merged

Add fee percentage validation in GlobalParams contract (OZ-32) #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/GlobalParams.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ contract GlobalParams is Initializable, IGlobalParams, OwnableUpgradeable, UUPSU

bytes32 private constant ZERO_BYTES = 0x0000000000000000000000000000000000000000000000000000000000000000;

/// @dev 100% in basis points; fee percentages must not exceed this and their sum must be below it.
uint256 private constant PERCENT_DIVIDER = 10000;

/**
* @dev Emitted when a platform is enlisted.
* @param platformHash The identifier of the enlisted platform.
Expand Down Expand Up @@ -198,6 +201,16 @@ contract GlobalParams is Initializable, IGlobalParams, OwnableUpgradeable, UUPSU
*/
error GlobalParamsPlatformLineItemTypeNotFound(bytes32 platformHash, bytes32 typeId);

/**
* @dev Throws when a fee percentage exceeds the maximum allowed (PERCENT_DIVIDER / 100%).
*/
error GlobalParamsFeePercentExceedsMax();

/**
* @dev Throws when the sum of protocol and platform fee percentages would exceed 100%.
*/
error GlobalParamsCombinedFeesExceedMax();

/**
* @dev Reverts if the input address is zero.
*/
Expand Down Expand Up @@ -246,6 +259,10 @@ contract GlobalParams is Initializable, IGlobalParams, OwnableUpgradeable, UUPSU
__Ownable_init(protocolAdminAddress);
__UUPSUpgradeable_init();

if (protocolFeePercent > PERCENT_DIVIDER) {
revert GlobalParamsFeePercentExceedsMax();
}

GlobalParamsStorage.Storage storage $ = GlobalParamsStorage._getGlobalParamsStorage();
$.protocolAdminAddress = protocolAdminAddress;
$.protocolFeePercent = protocolFeePercent;
Expand Down Expand Up @@ -413,7 +430,13 @@ contract GlobalParams is Initializable, IGlobalParams, OwnableUpgradeable, UUPSU
if (platformHash == ZERO_BYTES) {
revert GlobalParamsInvalidInput();
}
if (platformFeePercent > PERCENT_DIVIDER) {
revert GlobalParamsFeePercentExceedsMax();
}
GlobalParamsStorage.Storage storage $ = GlobalParamsStorage._getGlobalParamsStorage();
if ($.protocolFeePercent + platformFeePercent > PERCENT_DIVIDER) {
revert GlobalParamsCombinedFeesExceedMax();
}
if ($.platformIsListed[platformHash]) {
revert GlobalParamsPlatformAlreadyListed(platformHash);
} else {
Expand Down Expand Up @@ -504,6 +527,9 @@ contract GlobalParams is Initializable, IGlobalParams, OwnableUpgradeable, UUPSU
* @inheritdoc IGlobalParams
*/
function updateProtocolFeePercent(uint256 protocolFeePercent) external override onlyOwner {
if (protocolFeePercent > PERCENT_DIVIDER) {
revert GlobalParamsFeePercentExceedsMax();
}
GlobalParamsStorage.Storage storage $ = GlobalParamsStorage._getGlobalParamsStorage();
$.protocolFeePercent = protocolFeePercent;
Comment thread
mahabubAlahi marked this conversation as resolved.
emit ProtocolFeePercentUpdated(protocolFeePercent);
Expand Down