Skip to content

Add error handling for platform data key ownership in CampaignInfo contract #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahabubAlahi wants to merge 1 commit into
base: oz-audit-fixes
Choose a base branch
from
Open

Add error handling for platform data key ownership in CampaignInfo contract #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/CampaignInfo.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,13 @@ contract CampaignInfo is
*/
error CampaignInfoIsLocked();

/**
* @dev Throws when a platform data key is not owned by the platform being updated.
* @param platformHash The platform being updated.
* @param platformDataKey The key that does not belong to this platform.
*/
error CampaignInfoPlatformDataKeyNotOwnedByPlatform(bytes32 platformHash, bytes32 platformDataKey);

/**
* @dev Modifier that checks if the campaign is not locked.
*/
Expand Down Expand Up @@ -578,6 +585,9 @@ contract CampaignInfo is
if (!isValid) {
revert CampaignInfoInvalidInput();
}
if (globalParams.getPlatformDataOwner(platformDataKey[i]) != platformHash) {
revert CampaignInfoPlatformDataKeyNotOwnedByPlatform(platformHash, platformDataKey[i]);
}
if (platformDataValue[i] == bytes32(0)) {
revert CampaignInfoInvalidInput();
}
Expand Down
Loading