Skip to content

Add pre campaign launch constraint to removeReward #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adnanhq wants to merge 1 commit into
base: oz-audit-fixes
Choose a base branch
from
Open

Add pre campaign launch constraint to removeReward #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/treasuries/AllOrNothing.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ contract AllOrNothing is IReward, BaseTreasury, TimestampChecker, ReentrancyGuar
function removeReward(bytes32 rewardName)
external
onlyCampaignOwner
currentTimeIsLess(INFO.getLaunchTime())
whenCampaignNotPaused
whenNotPaused
whenCampaignNotCancelled
Expand Down
1 change: 1 addition & 0 deletions src/treasuries/KeepWhatsRaised.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,7 @@ contract KeepWhatsRaised is IReward, BaseTreasury, TimestampChecker, ICampaignDa
function removeReward(bytes32 rewardName)
external
onlyCampaignOwner
currentTimeIsLess(INFO.getLaunchTime())
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Gate reward removal on treasury launch time

removeReward now checks currentTimeIsLess(INFO.getLaunchTime()), but this contract’s runtime schedule is driven by s_campaignData.launchTime (set in configureTreasury) and pledge gating uses getLaunchTime(). Because configureTreasury does not enforce campaignData.launchTime == INFO.getLaunchTime(), these values can diverge, so reward removal can be incorrectly blocked before this treasury’s launch or incorrectly allowed after it, depending on which timestamp is earlier.

Useful? React with 👍 / 👎.

whenCampaignNotPaused
whenNotPaused
whenCampaignNotCancelled
Expand Down