Skip to content

Add check to ensure accepted tokens list cannot contain duplicates #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adnanhq wants to merge 1 commit into
base: oz-audit-fixes
Choose a base branch
from
Open

Add check to ensure accepted tokens list cannot contain duplicates #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/CampaignInfo.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,22 +164,28 @@ contract CampaignInfo is
s_campaignData = campaignData;

// Store accepted tokens
uint256 tokenLen = acceptedTokens.length;
for (uint256 i = 0; i < tokenLen; ++i) {
uint256 len = acceptedTokens.length;
for (uint256 i = 0; i < len;) {
address token = acceptedTokens[i];
if (s_isAcceptedToken[token]) {
revert CampaignInfoInvalidInput();
}
s_acceptedTokens.push(token);
s_isAcceptedToken[token] = true;
unchecked { ++i; }
}

uint256 len = selectedPlatformHash.length;
for (uint256 i = 0; i < len; ++i) {
len = selectedPlatformHash.length;
for (uint256 i = 0; i < len;) {
s_platformFeePercent[selectedPlatformHash[i]] =
_getGlobalParams().getPlatformFeePercent(selectedPlatformHash[i]);
s_isSelectedPlatform[selectedPlatformHash[i]] = true;
unchecked { ++i; }
}
len = platformDataKey.length;
for (uint256 i = 0; i < len; ++i) {
for (uint256 i = 0; i < len;) {
s_platformData[platformDataKey[i]] = platformDataValue[i];
unchecked { ++i; }
}

// Initialize NFT metadata
Expand Down