Spare pieces count#190
Conversation
|
Thanks for the pull request. Feature or bug? |
|
It seems to be a bug. Since I opened this PR, I heavily updated the code in my own fork (removed jquery, turned a lot of the code into |
|
Thanks. Just a feature request beyond what you have accomplished. It would be great if you entirely remove spare pieces with count==0 |
|
Ah no, my bad. Moving off the board is not supposed to increase the spare count. Just double-checked locally. As for not displaying pieces with count==0, I can do it in follow-up PR with a specific config if you want. |
|
Thank you for this! Exactly what I needed. However, this change makes the animation on .move() not smooth anymore. At least for me. |
First of all: this is very useful for the crazy house variant and is a bit complicated to work around for the moment so I decided to take a look at it.
In the end, I updated the #128 PR (the UI is different for example).
Also: the first commit is just a cleanup for some weird
\rin the code (made automatically by my text editor).Here's a screen of what it looks like: