Add option to record Embark targets in minibuffer history#785
Add option to record Embark targets in minibuffer history#785ultronozm wants to merge 1 commit intooantolin:masterfrom
Conversation
|
Thanks, this looks like a good addition - not unexpected that I would say that given that I opened the issue. Let's hope that @oantolin agrees. ;) Did you use this for a few days, and tested various completion commands/packages with it, e.g., Consult, just to see that it works as expected? |
ultronozm
force-pushed
the
feat/minibuffer-history
branch
from
98dd512 to
856daad
Compare
I have (with Consult and other popular packages), although any specific suggestions for what might be worth testing would be very welcome. |
ultronozm
force-pushed
the
feat/minibuffer-history
branch
from
856daad to
ee4a2aa
Compare
| ACTIONS@dots{})} to record for everything except the listed actions. | ||
| The default is a @samp{skip} form that excludes meta commands such as | ||
| @samp{embark-export}. | ||
|
|
There was a problem hiding this comment.
This should be generated from the Org file.
There was a problem hiding this comment.
Thanks, I see.
When I attempt to export the texinfo myself (via org-texinfo-export-to-texinfo), the resulting embark.texi differs in many places from what's in the repo. Is there some other way to do this? Or should I just update README.org in the PR, and leave it to @oantolin to export to texinfo?
There was a problem hiding this comment.
I usually do it manually and just keep the relevant changes in the texinfo. But in my setup the difference is not that large.
Addresses oantolin#712. * embark.el (embark-record-minibuffer-history): New user option to control when acted-on minibuffer candidates are recorded in the minibuffer history. Defaults to skipping certain actions, such as export, collect, and become. (embark--record-history-p, embark--record-target-in-history): New helper functions. (embark--act): Use them to record target in history. * README.org (Advanced configuration): * embark.texi (Advanced configuration): Document the new option.
ultronozm
force-pushed
the
feat/minibuffer-history
branch
from
ee4a2aa to
fbdad2c
Compare
|
@oantolin What do you think about this addition? It solves a common problem - I often miss recent candidates if they hadn't been selected during completion, but only acted on. This matters if candidates are sorted by history, e.g., as in Vertico. |
|
@ultronozm Did you assign copyright of your Emacs to the FSF? Embark is distributed as part of GNU ELPA. |
Yes, all set there (I've authored a few ELPA packages and Emacs/AUCTeX patches) |
|
@oantolin Do you have an opinion about this PR? I think it is a good addition, and I wanted to have this before, but I have not tested the patch. |
2 participants
Addresses #712.
control when acted-on minibuffer candidates are recorded in the
minibuffer history. Defaults to skipping certain actions, such as
export, collect, and become.
(embark--record-history-p, embark--record-target-in-history): New
helper functions.
(embark--act): Use them to record target in history.