Skip to content
This repository was archived by the owner on Nov 23, 2021. It is now read-only.

Added a growl warning when user has no access for the state#68

Open
tomaszwawrzyniakit wants to merge 2 commits intooasp:developmentfrom
tomaszwawrzyniakit:development
Open

Added a growl warning when user has no access for the state#68
tomaszwawrzyniakit wants to merge 2 commits intooasp:developmentfrom
tomaszwawrzyniakit:development

Conversation

@tomaszwawrzyniakit
Copy link
Copy Markdown
Contributor

No description provided.

@oasp-ci
Copy link
Copy Markdown

oasp-ci commented Oct 8, 2015

Can one of the admins verify this patch?

@dumbNickname
Copy link
Copy Markdown
Contributor

Hi,

I had a look at the changes and there is a small thing bothering me. The code itself look fine, but do we want to make security module depend on modules such as 'angular-growl' and 'oasp.oaspI18n'? Security module has some good defined and enclosed functionality. What if somebody wants to use this module but he/she would like to handle access denied warnings in a different way (not growl messages)? I would suggest to keep the module hermetic.

Cheers,
Bartek

@Devonfw-ci
Copy link
Copy Markdown

Can one of the admins verify this patch?

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 21, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants