Implement unlimited-depth directly-optimal recursion.#83
Draft
obi1kenobi wants to merge 32 commits intomainfrom
Draft
Implement unlimited-depth directly-optimal recursion.#83obi1kenobi wants to merge 32 commits intomainfrom
obi1kenobi wants to merge 32 commits intomainfrom
Conversation
Owner
Author
|
Unlimited-depth recursion makes adapters even more likely to accidentally trigger the same re-entrancy bug as in #205. The best way I can see is making a change to the |
15f64a4 to
64ebfd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a new directly-optimal recursion execution algorithm that can support unlimited-depth recursion, developed in collaboration with @bojanserafimov as part of the HYTRADBOI'22 Jam: https://www.hytradboi.com/jam
Traces show that the new implementation produces the first result in less than half as many steps on even the shallowest of recursion situations. The more steps previously involved in getting the first result from the recursion, the more significant the improvement will be.
After this merges, we'll still need to update the front-end to make the
@recursedepth parameter nullable and plumb that change throughout Trustfall to enable unlimited-depth recursion.