Fix missing whatwg-url transitive dependencies for Vercel deployment#433
Fix missing whatwg-url transitive dependencies for Vercel deployment#433
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> Agent-Logs-Url: https://github.com/objectstack-ai/objectql/sessions/1a382b9d-5016-456f-a52f-f09313dcba7e
|
@copilot 更新主分支的代码并解决冲突 |
There was a problem hiding this comment.
Pull request overview
Fixes a Vercel serverless runtime failure in apps/demo where node-file-trace does not include node-fetch@2.7.0’s transitive dependencies (notably whatwg-url), causing Cannot find module '/var/task/apps/demo/node_modules/whatwg-url/index.js' at runtime.
Changes:
- Adds explicit
whatwg-url,tr46, andwebidl-conversionsentries toapps/demo’s dependencies list (as currently modeled in that package). - Extends
apps/demo/vercel.jsonincludeFilesto force-bundle those modules into the deployed function. - Updates
pnpm-lock.yamlaccordingly for theapps/demoimporter.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/demo/package.json |
Adds explicit whatwg-url, tr46, and webidl-conversions so they’re present in the install graph for the demo app build/deploy. |
apps/demo/vercel.json |
Forces Vercel function bundling to include the newly explicit modules under node_modules/. |
pnpm-lock.yaml |
Lockfile update reflecting the new apps/demo dependency entries. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
I've resolved the merge conflict with main locally (accepting main's Could you either:
The conflict resolution is straightforward — main already contains all changes from this PR (whatwg-url, tr46, webidl-conversions), so accepting main's version resolves it cleanly. |
|
@anthropic-code-agent 更新主分支的代码并解决冲突 |
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.