Minor feature and compatibility improvements.#9
Open
silasp wants to merge 6 commits intoobukhow:masterfrom
Open
Minor feature and compatibility improvements.#9silasp wants to merge 6 commits intoobukhow:masterfrom
silasp wants to merge 6 commits intoobukhow:masterfrom
Conversation
Added logic to resize the placeholder image.
Owner
|
Hi! Thank you for contributing! Unfortunately I cannot accept your pull-request because of license issues. You should not contribute any code with Magento copyrights, so you should exclude |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I used your code on a recent project and made some slight modifications:
[1] Automatically resizes the placeholder image (if possible)
[2] Updates Gd2.php to prevent issues if the php memory limit has been configured in Gb.