feat: Add merlin support to dune tools #12972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benodiwal
force-pushed
the
pkg-support-merlin-dune-tools
branch
2 times, most recently
from
5cc1be4 to
5cd1626
Compare
shonfeder
reviewed
Dec 15, 2025
test/blackbox-tests/test-cases/pkg/merlin/dev-tool-merlin-no-lock-dir.t
Outdated
Show resolved
Hide resolved
test/blackbox-tests/test-cases/pkg/merlin/dev-tool-merlin-no-ocaml-lockfile.t
Outdated
Show resolved
Hide resolved
test/blackbox-tests/test-cases/pkg/merlin/dev-tool-merlin-no-lock-dir.t
Outdated
Show resolved
Hide resolved
benodiwal
force-pushed
the
pkg-support-merlin-dune-tools
branch
from
11990cc to
109420f
Compare
Leonidas-from-XIV
previously requested changes
Dec 16, 2025
Collaborator
Leonidas-from-XIV
left a comment
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Looks quite good overall, a few comments on style and how to simplify it a bit.
test/blackbox-tests/test-cases/pkg/merlin/dev-tool-merlin-basic.t
Outdated
Show resolved
Hide resolved
test/blackbox-tests/test-cases/pkg/merlin/dev-tool-merlin-relock-on-ocaml-version-change.t
Outdated
Show resolved
Hide resolved
test/blackbox-tests/test-cases/pkg/merlin/dev-tool-merlin-basic.t
Outdated
Show resolved
Hide resolved
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
benodiwal
force-pushed
the
pkg-support-merlin-dune-tools
branch
from
9ccc385 to
fbc93fe
Compare
Contributor
Author
|
Hey @Leonidas-from-XIV I have made the changes |
Alizter
reviewed
Dec 16, 2025
Collaborator
Leonidas-from-XIV
left a comment
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Apart from the flag and the many newlines that @Alizter already mentioned this is ready to go.
test/blackbox-tests/test-cases/pkg/merlin/dev-tool-merlin-relock-on-ocaml-version-change.t
Outdated
Show resolved
Hide resolved
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
Contributor
Author
|
Made the changes |
shonfeder
approved these changes
Dec 16, 2025
Member
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Alizter
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12915