expose escrow addresses in status endpoint#1223
Merged
Conversation
Member
Author
|
/run-security-scan |
alexcos20
commented
Feb 23, 2026
Member
Author
alexcos20
left a comment
There was a problem hiding this comment.
AI automated code review (Gemini 3).
Overall risk: low
Summary:
This pull request enhances the OceanNodeStatus by including the escrow contract address for each supported blockchain network. It introduces a new type AddressPerChain to represent a map of chain IDs to their respective escrow addresses and populates this field in the status handler by iterating through configured networks.
Comments:
• [INFO][other] It would be beneficial to add a unit test for statusHandler.ts to ensure that the escrowAddress field is correctly populated for all supported chains in the OceanNodeStatus output. This helps verify the new functionality and prevents regressions.
denisiuriet
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose escrowAddress to status endpoint:
{ "id": "16Uiu2HAmENNgCY1QAdQrPxipgUCQjyookUgpnbgXua4ZMju4Rkou", "publicKey": "031975be855cc6a72cb7a678b9b01bdb489cacf421c64de6c1ee790c502969499c", "friendlyName": "jersey-mirror-saturn-november", "address": "0xf9C5B7eE7708efAc6dC6Bc7d4b0455eBbf22b519", "version": "0.2.3", "http": true, "p2p": true, "provider": [ { "chainId": "8453", "network": "base" }, { "chainId": "11155111", "network": "sepolia" } ], "indexer": [ { "chainId": "8453", "network": "base", "block": "0" }, { "chainId": "11155111", "network": "sepolia", "block": "0" } ], "escrowAddress": { "8453": "0xf0c7A31D7Ee26bEBfb4BAD8e37490bEadE3F846f", "11155111": "0x8149276f275EEFAc110D74AFE8AFECEaeC7d1593" }, "supportedStorage": { "url": true, "arwave": true, "ipfs": true }, "platform": { "cpus": 16, "freemem": 28159803392, "totalmem": 33613332480, "loadavg": [ 0.19, 0.15, 0.05 ], "arch": "x64", "machine": "x86_64", "platform": "linux", "osType": "Linux", "node": "v22.4.1" }, "codeHash": "b4aa292c4eebee978e09a854f998b14a698a90d03fddc73e3da89e6acbb13f67", "allowedAdmins": { "addresses": [], "accessLists": null }, "uptime": 8.10429164 }