Skip to content

Conversation

@giwa
Copy link

@giwa giwa commented Dec 16, 2015

This PR has :

  • fix the bug, draft/test_svd.py misses std
  • trailing white spaces are deleted.

Review on Reviewable

@ocelma
Copy link
Owner

ocelma commented Dec 16, 2015

Why do you need to import std from numpy?
Looks like you're not using it in any nose test (See the diffs: https://github.com/ocelma/python-recsys/pull/17/files#diff-0 )


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@giwa
Copy link
Author

giwa commented Jan 17, 2016

@ocelma

https://github.com/ocelma/python-recsys/blob/master/draft/test_svd.py#L74
I thought this std function should come from numpy.

@ocelma
Copy link
Owner

ocelma commented Jan 17, 2016

I see.
Looks like an option would be to add this:

from numpy import nan, mean, std # <- std function imported now from numpy

On Sun, 17 Jan 2016 at 10:07 Ken Takagiwa notifications@github.com wrote:

@ocelma https://github.com/ocelma

https://github.com/ocelma/python-recsys/blob/master/draft/test_svd.py#L74
I thought this std function should come from numpy.


Reply to this email directly or view it on GitHub
#17 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants