Skip to content

Support JIT plugin version wildcards #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bailey-coding wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Support JIT plugin version wildcards #1287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ export default class Plugins {
// a not valid tag indicates that it's a dist-tag like 'latest'
if (!valid(p.tag)) return `${p.name}@${p.tag}`

if (p.tag && valid(p.tag) && jitPlugins[p.name] && gt(p.tag, jitPlugins[p.name])) {
if (p.tag && valid(p.tag) && jitPlugins[p.name] && valid(jitPlugins[p.name]) && gt(p.tag, jitPlugins[p.name])) {
// The user has installed a version of the JIT plugin that is newer than the one
// specified by the root plugin's JIT configuration. In this case, we want to
// keep the version installed by the user.
Expand Down