add UI test for select tag in webview#179
add UI test for select tag in webview#179starboi02 wants to merge 2 commits intoodk-x:developmentfrom
Conversation
|
Can one of the admins verify this patch? Also need an authorization to run tests. |
|
@linl33 can you please review this PR |
|
runtests |
wbrunette
left a comment
wbrunette
left a comment
There was a problem hiding this comment.
Please make sure the PR compile against the build variant snapshotUiTestDebug.
| int numOfMsToSleep = 0; | ||
| for (int i = 0; i < numOfTimesToRun; i++) { | ||
| boolean found = false; | ||
| Atom<ElementReference> elementFound = findElement(DriverAtoms.findElement(Locator.SELECT, "select")); |
There was a problem hiding this comment.
The first findElement uses your static import the second one is missing an import statement so it won't compile
There was a problem hiding this comment.
Also Locator.SELECT is not resolving
There was a problem hiding this comment.
I have resolved the errors and compiled it against build variant snapshotUiTestDebug
@wbrunette can you please guide me on how to do it. |
|
Check out this PR odk-x/docs#77 that is in-progress to improve the instructions on how to change the build variant. |
|
@wbrunette thanks, It cleared my doubt. |
|
@wbrunette please review it I have made the requested changes |
|
Have you run it to verify you test does what you think it does? To run the UI tests you must have a development version (compiled by you and installed on the device or emulator) of Services and Survey. Then you need to do a "grunt adbpush" of app-designer to setup everything correctly. Also you need OI File manager installed. |
|
@starboi02 Your changes should also include an HTML component to test |
Ok @linl33 I will add that and component and recreate the crash with androidcommon version specified by you. |
Ok @wbrunette I will run it with the correct androidcommon version. |
|
@starboi02 any update on this PR? |
|
@wbrunette sorry for the delay I got infected with covid-19 so could not contribute for a time period. I will try to complete it in a day or two. |
|
@starboi02 no worries. I am was simply going through all the PRs to make sure that PRs were not waiting on review. Hope you recovery from COVID-19 is going well. No need to rush, you can take your time. |
4 participants
Fixes #209
Added UI test for select tag in webview